update deprecated API patterns in sync with serialport 4.x#43
Open
noopkat wants to merge 2 commits intogarrows:masterfrom
Open
update deprecated API patterns in sync with serialport 4.x#43noopkat wants to merge 2 commits intogarrows:masterfrom
noopkat wants to merge 2 commits intogarrows:masterfrom
Conversation
Contributor
|
👍 Also, these changes likely mean I'll be able to use avr109/leonardo on avrgirl from a browser :) |
|
This is the major change. 👍 to that. The other major one is in the constructer. We now always throw errors during construction. The callback is now called |
Added isOpen() method to improve compatibility with node-serialport.
Contributor
Contributor
|
@reconbot or the serialport org. can't remember where we ended up on orgs after the j5 summit :) |
|
I don't want to use the nodebots org yet as I haven't identified all the
people who have full control there. A lot of inactive accounts with full
access to everything. I setup a governance model for SerialPort so until
Nodebots is sorted, let's use that. 👍
…On Sun, Sep 30, 2018, 11:05 AM Luis Montes ***@***.***> wrote:
@reconbot <https://github.com/reconbot> or the serialport org. can't
remember where we ended up on orgs after the j5 summit :)
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#43 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABlbnMZEEbgVK_3kDJ8POCP5Ak8goOrks5ugOvTgaJpZM4JOSu1>
.
|
Contributor
|
@garrows will initiate the transfer of this one to serialport, and we can merge this when it gets there |
|
@garrows this makes you serialport maintainer, you should have permission to transfer the repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋 Hello!
I'm opening this pull request to sync up some API differences that have occured between
browser-serialportandnode-serialport.For some background on why it'd be great to keep them in sync:
@monteslu opened this rad pull request on one of my libraries: noopkat/avrgirl-arduino#78
I would love to merge it, however my library uses the latest version of
node-serialport, so this would call the wrong things inbrowser-serialportwhen it's packaged up for web use.Thanks for this awesome library - this is really helpful to a lot of folks in the nodebots community 💓